Skip to content

[2.4] Restrict Routes based on Security Context. #9495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henrikbjorn opened this issue Nov 12, 2013 · 6 comments
Closed

[2.4] Restrict Routes based on Security Context. #9495

henrikbjorn opened this issue Nov 12, 2013 · 6 comments
Labels

Comments

@henrikbjorn
Copy link
Contributor

For some applications it would be nice to have a homepage route that displays marketing stuff for signing up like GitHub does, and then have a homepage_authenticated Route other wise.

With the new ExpressionLanguage and conditionals can this be done?

@stof
Copy link
Member

stof commented Nov 12, 2013

@henrikbjorn no, because the firewall runs after the router (because it needs the router to be initialized to be able to use it)

@henrikbjorn
Copy link
Contributor Author

Why does the SecurityContext need the Router? I think it creates a lot of limitations.

@stof
Copy link
Member

stof commented Nov 12, 2013

because it supports using a route name for the login path rather than a path (useful in case you want to use th locale in the login url for instance)

@henrikbjorn
Copy link
Contributor Author

Sounds like a trade off, what is most powerful/useful.

@stof
Copy link
Member

stof commented Nov 12, 2013

@henrikbjorn the issue is that it would require removing a feature to add another one, and so break BC

@fabpot
Copy link
Member

fabpot commented Apr 28, 2014

Closing as this has been debated a lot and there is another issue about this (see #2679).

@fabpot fabpot closed this as completed Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants