-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[2.4] Restrict Routes based on Security Context. #9495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@henrikbjorn no, because the firewall runs after the router (because it needs the router to be initialized to be able to use it) |
Why does the SecurityContext need the Router? I think it creates a lot of limitations. |
because it supports using a route name for the login path rather than a path (useful in case you want to use th locale in the login url for instance) |
Sounds like a trade off, what is most powerful/useful. |
@henrikbjorn the issue is that it would require removing a feature to add another one, and so break BC |
Closing as this has been debated a lot and there is another issue about this (see #2679). |
For some applications it would be nice to have a
homepage
route that displays marketing stuff for signing up like GitHub does, and then have ahomepage_authenticated
Route other wise.With the new ExpressionLanguage and
conditionals
can this be done?The text was updated successfully, but these errors were encountered: