Skip to content

[Routing] Deprecate the Apache dumper #9652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Nov 29, 2013 · 11 comments
Closed

[Routing] Deprecate the Apache dumper #9652

fabpot opened this issue Nov 29, 2013 · 11 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Routing

Comments

@fabpot
Copy link
Member

fabpot commented Nov 29, 2013

The performance gains are minimal and it's very hard (or even impossible) to replicate the exact same behavior.

I propose that we deprecate the Apache dumper in 2.5 and remove it in 3.0.
@sstok
Copy link
Contributor

sstok commented Nov 29, 2013

👍

1 similar comment
@stof
Copy link
Member

stof commented Nov 29, 2013

👍

@stof stof mentioned this issue Nov 29, 2013
Closed
@cordoval
Copy link
Contributor

👍

3 similar comments
@gnugat
Copy link
Contributor

gnugat commented Dec 1, 2013

👍

@paxal78
Copy link

paxal78 commented Dec 1, 2013

👍

@XWB
Copy link
Contributor

XWB commented Dec 1, 2013

👍

@jameshalsall
Copy link
Contributor

@fabpot do we have any existing benchmarks which demonstrate the performance gain? or is this largely dependent on web server configuration?

@cordoval
Copy link
Contributor

cordoval commented Dec 5, 2013

cross referencing here #5996 so that it will be closed when deprecating the dumper

@vamsiikrishna
Copy link

👍

@cordoval cordoval mentioned this issue Dec 7, 2013
Closed
@rodrigodiez
Copy link

Hi, I'm working in a PR. What about ApacheUrlMatcher? Should it be deprecated too?

@fabpot
Copy link
Member Author

fabpot commented Dec 30, 2013

@rodrigodiez Yes, Apache support as a whole.

@jakzal jakzal mentioned this issue Jan 8, 2014
Closed
This was referenced Jan 13, 2014
Closed
Closed
fabpot added a commit that referenced this issue Jan 13, 2014
@fabpot
feature #9980 [Routing][FrameworkBundle] Deprecated the apache dumper…
916420f 
… (jakzal)

This PR was squashed before being merged into the 2.5-dev branch (closes #9980).

Discussion
----------

[Routing][FrameworkBundle] Deprecated the apache dumper

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #9652
| License       | MIT
| Doc PR        | symfony/symfony-docs#3446

Commits
-------

6258cfa [Routing][FrameworkBundle] Deprecated the apache dumper
@fabpot fabpot closed this as completed Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@fabpot @cordoval @paxal78 @stof @jameshalsall @vamsiikrishna @gnugat @rodrigodiez @sstok @XWB