[Security] Use hash_equals when available for constant-time string comparison #11795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should probably be done in 2.3, no? |
|
👍 |
|
agree with @fabpot for merging it in 2.3 as it's a security improvement and should not break BC. |
|
+1 for 2.3. I recreate a PR. |
|
@dunglas Recreating the PR is not needed most of the time. We can rebase the branch automatically when merging if it applies cleanly |
|
@pborreli it is not really a security improvement. It simply relies on the constant-time comparison implemented in C when available rather than using the PHP implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
hash_equalsfunction (introduced in PHP 5.6) for timing attack safe string comparison when available.