[FrameworkBundle] enable ErrorHandler in prod #12081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Sep 30, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11053, #8281 |
| License | MIT |
| Doc PR | - |
- a new debug.error_handler service is the registered PHP error handler, with ErrorHandler::register() as factory
- ErrorHandler::register() is patched so that it checks if the currently registered error handler is an instance of ErrorHandler - in which case it returns this instance and don't create a new one.
- DebugHandlersListener now listen to ConsoleEvents and re-injects fatal errors within the $app->renderException code path
- DebugHandlersListener also has a new $scream parameter to control if silenced errors are logged or not
af0ecf4 to
c3d012c
Compare
|
This PR is ready for review/vote. I updated the patch to have almost no behavioral change but only semantic added-value. |
f3943a9 to
423a286
Compare
423a286 to
4acf5d3
Compare
|
looks good to me. 👍 |
| @@ -6,7 +6,9 @@ | |||
|
|
|||
| <parameters> | |||
| <parameter key="debug.debug_handlers_listener.class">Symfony\Component\HttpKernel\EventListener\DebugHandlersListener</parameter> | |||
| <parameter key="debug.error_handler.class">Symfony\Component\Debug\ErrorHandler</parameter> | |||
There was a problem hiding this comment.
I think we don't want to introduce more of these params.
c12db68 to
9bb0f83
Compare
| <argument>null</argument><!-- %templating.helper.code.file_link_format% --> | ||
| </service> | ||
|
|
||
| <service id="debug.error_handler" class="Symfony\Component\Debug\ErrorHandler" factory-class="Symfony\Component\Debug\ErrorHandler" factory-method="register" public="false"> |
There was a problem hiding this comment.
Now that it is private I can drop it you're right.
I may reintroduce it later to bind it to new configuration options for controlling scope_at and trace_at,
that's why I added it in the first place.
Removing for now.
9bb0f83 to
fac3cc4
Compare
|
That the console now correctly displays fatal errors is cool. But this will only be working when using the framework bundle. Can this not be handled within the component? |
|
Having this in the framework bundle allows configuration flexibility. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2014
…-grekas) This PR was merged into the 2.6-dev branch. Discussion ---------- [FrameworkBundle] enable ErrorHandler in prod | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11053, #8281 | License | MIT | Doc PR | - - a new debug.error_handler service is the registered PHP error handler, with ErrorHandler::register() as factory - ErrorHandler::register() is patched so that it checks if the currently registered error handler is an instance of ErrorHandler - in which case it returns this instance and don't create a new one. - DebugHandlersListener now listen to ConsoleEvents and re-injects fatal errors within the $app->renderException code path - DebugHandlersListener also has a new $scream parameter to control is silenced errors are logged or not Commits ------- fac3cc4 [FrameworkBundle] register ErrorHandler at boot time 4acf5d3 [Debug] make screaming configurable 4d0ab7d [FrameworkBundle] enable ErrorHandler in prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.