[HttpFoundation] Make Request::get() more performant #12537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
@nicolas-grekas there is some tests broken on PHP 5.3 in the Debug component. Could you look at them ? |
|
What about merging this in 2.3? |
|
Thanks Christian! On Fri, Nov 21, 2014, 8:01 AM Fabien Potencier notifications@github.com
|
|
@fabpot 👍 for 2.3 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 21, 2014
…rvinSzanto, xabbuh) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #12537). Discussion ---------- [HttpFoundation] Make Request::get() more performant | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This finishes the work started by @KorvinSzanto in #12369. Commits ------- 3039935 reformat code as suggested by @fabpot ad64223 Fix typo 4162713 Make `\Request::get` more performant.
|
@KorvinSzanto Thank you for the initial commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the work started by @KorvinSzanto in #12369.