From bd1b11dbb0a1251afc90a3c0f81530ab33ff64d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Borrego=20Bernab=C3=A9?= Date: Sat, 29 Nov 2014 14:39:12 +0100 Subject: [PATCH 1/3] Adding a deprecation note about DialogHelper --- src/Symfony/Component/Console/Helper/DialogHelper.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php index 589568ec78892..af65790a519ed 100644 --- a/src/Symfony/Component/Console/Helper/DialogHelper.php +++ b/src/Symfony/Component/Console/Helper/DialogHelper.php @@ -20,7 +20,7 @@ * @author Fabien Potencier * * @deprecated Deprecated since version 2.5, to be removed in 3.0. - * Use the question helper instead. + * Use {@link \Symfony\Component\Console\Helper\QuestionHelper} instead. */ class DialogHelper extends InputAwareHelper { @@ -28,6 +28,12 @@ class DialogHelper extends InputAwareHelper private static $shell; private static $stty; + function __construct() + { + trigger_error( 'DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED ); + + parent::__construct(); + } /** * Asks the user to select a value. * From 265597d9532018aed1633e7f322abd1b4b8b7ed2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Borrego=20Bernab=C3=A9?= Date: Sat, 29 Nov 2014 15:07:08 +0100 Subject: [PATCH 2/3] Coding style fixing --- src/Symfony/Component/Console/Helper/DialogHelper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php index af65790a519ed..8d76060d2299d 100644 --- a/src/Symfony/Component/Console/Helper/DialogHelper.php +++ b/src/Symfony/Component/Console/Helper/DialogHelper.php @@ -28,9 +28,9 @@ class DialogHelper extends InputAwareHelper private static $shell; private static $stty; - function __construct() + public function __construct() { - trigger_error( 'DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED ); + trigger_error('DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); parent::__construct(); } From d14d3d30e8d4b2f1c2f7e511f25b4ae289305ce8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Borrego=20Bernab=C3=A9?= Date: Sat, 29 Nov 2014 16:47:58 +0100 Subject: [PATCH 3/3] Moving deprecated warning outside of the constructor to have only one message --- src/Symfony/Component/Console/Helper/DialogHelper.php | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/DialogHelper.php b/src/Symfony/Component/Console/Helper/DialogHelper.php index 8d76060d2299d..5158677ef96ea 100644 --- a/src/Symfony/Component/Console/Helper/DialogHelper.php +++ b/src/Symfony/Component/Console/Helper/DialogHelper.php @@ -11,6 +11,8 @@ namespace Symfony\Component\Console\Helper; +trigger_error('\Symfony\Component\Console\Helper\DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); + use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Formatter\OutputFormatterStyle; @@ -28,12 +30,6 @@ class DialogHelper extends InputAwareHelper private static $shell; private static $stty; - public function __construct() - { - trigger_error('DialogHelper is deprecated since version 2.5 and will be removed in 3.0. Use QuestionHelper instead.', E_USER_DEPRECATED); - - parent::__construct(); - } /** * Asks the user to select a value. *