Skip to content

[Serializer] Add circular reference handling to the PropertyNormalizer #13255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2015

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jan 4, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
Doc PR n/a

Move circular references handling to AbstractNormalizer and use it in PropertyNormalizer.

@dunglas dunglas force-pushed the serializer_abstract_circular branch from 7018fee to fbc9335 Compare January 4, 2015 20:42
@fabpot
Copy link
Member

fabpot commented Jan 6, 2015

👍

@fabpot
Copy link
Member

fabpot commented Jan 7, 2015

Thank you @dunglas.

@fabpot fabpot merged commit fbc9335 into symfony:2.7 Jan 7, 2015
fabpot added a commit that referenced this pull request Jan 7, 2015
…opertyNormalizer (dunglas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] Add circular reference handling to the PropertyNormalizer

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | n/a

Move circular references handling to `AbstractNormalizer` and use it in `PropertyNormalizer`.

Commits
-------

fbc9335 [Serializer] Add circular reference handling to the PropertyNormalizer
@@ -37,6 +40,40 @@ public function __construct(ClassMetadataFactory $classMetadataFactory = null)
}

/**
* Set circular reference limit.
*
* @param $circularReferenceLimit limit of iterations for the same object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing type in the phpdoc

dunglas added a commit that referenced this pull request Mar 6, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] ObjectNormalizer

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR       | not yet

`PropertyAccessNormalizer` is a new normalizer leveraging the PropertyAccess Component. It is able to handle classes containing both public properties and properties only accessibles trough getters / setters / issers / hassers...

As it extends `AbstractNormalizer`, it supports circular reference handling, name converters and existing object population.
What do you think about making this new normalizer the default one as it's the most convenient to use and the most consistent with the behavior of other components.

#13120, #13252 and #13255 need to be merged to make this PR working.

Commits
-------

0050bbb [Serializer] Introduce ObjectNormalizer
@dunglas dunglas deleted the serializer_abstract_circular branch December 5, 2015 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants