[FrameworkBundle][Server Command] add address port number option. #14383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| $address = $input->getArgument('address'); | ||
| if (false === strpos($address, ':')) { | ||
| $address = $address.':'.$input->getOption('port'); | ||
| } |
There was a problem hiding this comment.
I think we should rather pass the built address here instead of doing this all again.
f4126bf to
83dbaae
Compare
|
|
||
| $address = $input->getArgument('address'); |
There was a problem hiding this comment.
Can you revert this change (i.e. moving the blank line down again)?
83dbaae to
fbe1a43
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Apr 18, 2015
…ber option. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][Server Command] add address port number option. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ This allow running server without repeating `127.0.0.1` each time, in the most of case we only change the port number. * Before ``` app/console server:start 127.0.0.1:8080 ``` * After ``` app/console server:start -p 8080 ``` Commits ------- fbe1a43 [FrameworkBundle][Server Command] add address port number option.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow running server without repeating
127.0.0.1each time, in the most of case we only change the port number.