Skip to content

[Filesystem] deprecate chmod support in dumpFile() #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 23, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The ability to support a custom permission mask in the dumpFile() method is deprecated since Symfony Symfony 2.3.12. This commit adds the trigger_error() call if a custom permission mask is passed.

@dosten
Copy link
Contributor

dosten commented Apr 23, 2015

👍 PD: trigger_error not error_trigger

The ability to support a custom permission mask in the `dumpFile()`
method is deprecated since Symfony Symfony 2.3.12. This commit adds the
`trigger_error()` call if a custom permission mask is passed.
@xabbuh
Copy link
Member Author

xabbuh commented Apr 23, 2015

indeed :D thanks

@dosten
Copy link
Contributor

dosten commented Apr 24, 2015

Hmmm.. this is weird:

Fatal error: Cannot redeclare class Symfony\Component\Debug\Exception\UndefinedFunctionException in /home/travis/build/symfony/symfony/src/Symfony/Component/Security/Http/vendor/symfony/debug/Symfony/Component/Debug/Exception/UndefinedFunctionException.php on line 33

@nicolas-grekas
Copy link
Member

See #14451

@fabpot
Copy link
Member

fabpot commented Apr 27, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit faee0d7 into symfony:2.7 Apr 27, 2015
fabpot added a commit that referenced this pull request Apr 27, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[Filesystem] deprecate chmod support in dumpFile()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The ability to support a custom permission mask in the `dumpFile()` method is deprecated since Symfony Symfony 2.3.12. This commit adds the `trigger_error()` call if a custom permission mask is passed.

Commits
-------

faee0d7 [Filesystem] deprecate chmod support in dumpFile()
@xabbuh xabbuh deleted the deprecate-chmod branch April 27, 2015 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants