Include working directory in ProcessFailedException #14908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. |
| $process->getCommandLine(), | ||
| $process->getExitCode(), | ||
| $process->getExitCodeText() | ||
| $process->getExitCodeText(), | ||
| $process->getWorkingDirectory() |
There was a problem hiding this comment.
I think we should skip it when it get null ?
There was a problem hiding this comment.
The goal is to improve error information if a process fails because of the lack of user rights on the working directory.
|
Looks like some indentation went wrong. |
|
@xabbuh at the |
| @@ -98,10 +103,11 @@ public function testDisabledOutputInFailedExceptionDoesNotPopulateOutput() | |||
| $cmd = 'php'; | |||
| $exitCode = 1; | |||
| $exitText = 'General error'; | |||
| $workingDirectory = getcwd(); | |||
There was a problem hiding this comment.
wrong indentation (missing 1 space)
affa688 to
4d83cea
Compare
... because quite often the Exception is a result of the `www-data` user not having the appropriate rights at that path. fixed ProcessFailedException tests Update ProcessFailedExceptionTest.php fix indention fixed indention
|
@jakzal you think this PR can be merged? |
| @@ -28,10 +28,11 @@ public function __construct(Process $process) | |||
| throw new InvalidArgumentException('Expected a failed process, but the given process was successful.'); | |||
| } | |||
|
|
|||
| $error = sprintf('The command "%s" failed.'."\nExit Code: %s(%s)", | |||
| $error = sprintf('The command "%s" failed.'."\n\nExit Code: %s(%s)\n\nWorking directory: %s", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you paste an output example?
|
Any news? |
|
Thank you @rvanlaak. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2015
…vanlaak) This PR was merged into the 2.8 branch. Discussion ---------- Include working directory in ProcessFailedException ... because quite often the Exception is a result of the `www-data` user not having the appropriate rights at that working path. Maybe @schmittjoh can confirm this? | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- dbaefb4 Include working directory in ProcessFailedException
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because quite often the Exception is a result of the
www-datauser not having the appropriate rights at that working path. Maybe @schmittjoh can confirm this?