[Security] Add missing docblock in PreAuthenticatedToken #15484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has bothered me for years. 👍 |
|
👍 |
|
What about this PR? Is there a problem with it? |
|
@fabpot ping, this can be merged |
|
Status: Reviewed |
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2015
… (tgalopin) This PR was merged into the 2.3 branch. Discussion ---------- [Security] Add missing docblock in PreAuthenticatedToken | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I noticed the `PreAuthenticatedToken` does not provide any dockblock about its constructor parameters so PHPStorm uses the `AbstractToken` parameters and think I'm using `PreAuthenticatedToken` badly. This fix it by adding the missing docblock and I also added the string[] possibility for roles in `AbstractToken` as it's present in the code and the exception message. Commits ------- 1dda0a6 [Security] Add missing docblock in PreAuthenticatedToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
PreAuthenticatedTokendoes not provide any dockblock about its constructor parameters so PHPStorm uses theAbstractTokenparameters and think I'm usingPreAuthenticatedTokenbadly.This fix it by adding the missing docblock and I also added the string[] possibility for roles in
AbstractTokenas it's present in the code and the exception message.