[Form] Guess currency field based on validator constraint #15919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enumag
commented
Sep 26, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
Looks like a correct addition, thanks @enumag! As this is probably considered a new feature, it'll be merged into the 2.8 branch (as new features can't be introduced in maintainance versions). You don't have to worry about this though, the merge tool used by the core team is able to do this very easily. Status: Reviewed |
|
@wouterj Thanks. I was not sure whether to consider this a new feature or not. |
|
Thank you @enumag. |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2015
…int (enumag) This PR was submitted for the 2.3 branch but it was merged into the 2.8 branch instead (closes #15919). Discussion ---------- [Form] Guess currency field based on validator constraint | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 2993b00 [Form] Guess currency field based on validator constraint
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.