Skip to content

[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8 #15929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[3.0][Config] Remove ResourceInterface::getResource() which was deprecated in 2.8 #15929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05cc4ab
Remove ResourceInterface::getResource() which was deprecated in 2.8
mpdude Sep 26, 2015
2c4f46b
Remove getResource() implementations in tests where they are not needed
mpdude Sep 27, 2015
4ffbb14
Remove @inheritdoc and add per-resource docblocks
mpdude Sep 27, 2015
a693792
Updated docblock to take realpath() effects into consideration
mpdude Sep 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/Config/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ CHANGELOG
* removed `ReferenceDumper` class
* removed the `ResourceInterface::isFresh()` method
* removed `BCResourceInterfaceChecker` class
* removed `ResourceInterface::getResource()` method

2.8.0
-----
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/Resource/DirectoryResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function __toString()
}

/**
* {@inheritdoc}
* @return string The file path to the resource
*/
public function getResource()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/Resource/FileExistenceResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function __toString()
}

/**
* {@inheritdoc}
* @return string The file path to the resource
*/
public function getResource()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/Resource/FileResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function __toString()
}

/**
* {@inheritdoc}
* @return string|false The canonicalized, absolute path to the resource or false if the resource does not exist.
*/
public function getResource()
{
Expand Down
13 changes: 0 additions & 13 deletions src/Symfony/Component/Config/Resource/ResourceInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,4 @@ interface ResourceInterface
* @return string A string representation unique to the underlying Resource
*/
public function __toString();

/**
* Returns the tied resource.
*
* @return mixed The resource
*
* @deprecated since 2.8, to be removed in 3.0. As there are many different kinds of resource,
* a single getResource() method does not make sense at the interface level. You
* can still call getResource() on implementing classes, probably after performing
* a type check. If you know the concrete type of Resource at hand, the return value
* of this method may make sense to you.
*/
public function getResource();
}
5 changes: 0 additions & 5 deletions src/Symfony/Component/Config/Tests/Resource/ResourceStub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,4 @@ public function isFresh($timestamp)
{
return $this->fresh;
}

public function getResource()
{
return 'stub';
}
}
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/Config/EnvParametersResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function __toString()
}

/**
* {@inheritdoc}
* @return array An array with two keys: 'prefix' for the prefix used and 'variables' containing all the variables watched by this resource
*/
public function getResource()
{
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/Translation/Tests/TranslatorCacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,6 @@ public function isFresh($timestamp)
return false;
}

public function getResource()
{
}

public function __toString()
{
return '';
Expand Down