Skip to content

Simplify AbstractVoter #16102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2015
Merged

Simplify AbstractVoter #16102

merged 1 commit into from
Oct 5, 2015

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Oct 4, 2015

Q A
Bug fix? no
New feature? no, just simplification
BC breaks? no, because 2.8 is not yet released
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@Koc Koc mentioned this pull request Oct 4, 2015
Closed
@Koc Koc force-pushed the simplify-abstract-voter branch from 8c8cfa1 to 93de659 Compare October 4, 2015 09:09
@Koc
Copy link
Contributor Author

Koc commented Oct 4, 2015

Does anybody know why php7 build fails?

@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2015

@Koc Seems to be related to some PHPUnit bug.

@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2015

👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Oct 5, 2015

Thank you @Koc.

@fabpot fabpot merged commit 93de659 into symfony:2.8 Oct 5, 2015
fabpot added a commit that referenced this pull request Oct 5, 2015
@fabpot
feature #16102 Simplify AbstractVoter (Koc)
3567548 
This PR was merged into the 2.8 branch.

Discussion
----------

Simplify AbstractVoter

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no, just simplification
| BC breaks?    | no, because 2.8 is not yet released
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

93de659 Simplify AbstractVoter
@TomasVotruba
Copy link
Contributor

Great job!

@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
@Koc Koc deleted the simplify-abstract-voter branch December 13, 2015 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Koc @xabbuh @fabpot @TomasVotruba @carsonbot