Skip to content

[Form] remove deprecated CSRF options #16723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2015
Merged

[Form] remove deprecated CSRF options #16723

merged 1 commit into from
Nov 28, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 28, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh force-pushed the remove-csrf-config-options branch from 75c68f3 to bb07b7e Compare November 28, 2015 11:02
@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2015

Should be rebased when #16722 is merged up to master.

@fabpot
Copy link
Member

fabpot commented Nov 28, 2015

@xabbuh Done

@xabbuh xabbuh force-pushed the remove-csrf-config-options branch from bb07b7e to d641fc5 Compare November 28, 2015 15:51
@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2015

rebased now that #16722 has been merged, this is ready to be reviewed

@Tobion
Copy link
Contributor

Tobion commented Nov 28, 2015

👍

Status: Reviewed

@jakzal
Copy link
Contributor

jakzal commented Nov 28, 2015

👍 status: reviewed

@Tobion
Copy link
Contributor

Tobion commented Nov 28, 2015

Could you also remvoe the deprecation from security?

@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2015

@Tobion Which deprecation do you mean?

@Tobion
Copy link
Contributor

Tobion commented Nov 28, 2015

Thank you @xabbuh.

@Tobion Tobion merged commit d641fc5 into symfony:master Nov 28, 2015
Tobion added a commit that referenced this pull request Nov 28, 2015
@Tobion
feature #16723 [Form] remove deprecated CSRF options (xabbuh)
07ac122 
This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] remove deprecated CSRF options

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

d641fc5 [Form] remove deprecated CSRF options
@Tobion
Copy link
Contributor

Tobion commented Nov 28, 2015

I thought the ones in Security/Http added in #16722. But they didnt make it in master apparently.

@xabbuh xabbuh deleted the remove-csrf-config-options branch November 28, 2015 16:19
@fabpot fabpot mentioned this pull request Nov 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @fabpot @Tobion @jakzal @carsonbot