Skip to content

[Yaml] do not remove "comments" in scalar blocks #16860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 5, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12478, #15857
License MIT
Doc PR

Inside scalar blocks, lines starting with a # character must be
treated like every other strings and must not be ignored as comments.

Inside scalar blocks, lines starting with a `#` character must be
treated like every other strings and must not be ignored as comments.
@xabbuh
Copy link
Member Author

xabbuh commented Dec 10, 2015

ping @symfony/deciders

@fabpot
Copy link
Member

fabpot commented Dec 18, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 3c72fcc into symfony:2.3 Dec 18, 2015
fabpot added a commit that referenced this pull request Dec 18, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] do not remove "comments" in scalar blocks

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12478, #15857
| License       | MIT
| Doc PR        |

Inside scalar blocks, lines starting with a `#` character must be
treated like every other strings and must not be ignored as comments.

Commits
-------

3c72fcc [Yaml] do not remove "comments" in scalar blocks
@xabbuh xabbuh deleted the issue-12478-15857 branch December 18, 2015 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants