[Console] Avoid extra blank lines when rendering exceptions #17040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -673,6 +673,8 @@ public function asXml($namespace = null, $asDom = false) | |||
| */ | |||
| public function renderException($e, $output) | |||
| { | |||
| $output->writeln(''); | |||
There was a problem hiding this comment.
Beware when merging in upper branches. Since 2.8, this should be:
- $output->writeln('');
+ $output->writeln('', OutputInterface::VERBOSITY_QUIET);|
👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
…s (ogizanagi) This PR was merged into the 2.3 branch. Discussion ---------- [Console] Avoid extra blank lines when rendering exceptions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Don't know if it can be considered as a bug fix as it is the behavior since a while (#9055), but I let you see by yourself the old vs new rendering:  Commits ------- 2e158df [Console] Avoid extra blank lines when rendering exceptions
nicolas-grekas
added a commit
that referenced
this pull request
Dec 23, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Console][2.7] Fix merge #17040 | Q | A | ------------- | --- | Fixed tickets | 6a92f4e#commitcomment-15080872 | License | MIT This change should not be merged in upper branches. Commits ------- 211d589 [Console][2.7] Fix merge #17040
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if it can be considered as a bug fix as it is the behavior since a while (#9055), but I let you see by yourself the old vs new rendering: