[Form] fix BC break introduced with prototype_data option #17044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $form = $this->factory->create('Symfony\Component\Form\Extension\Core\Type\CollectionType', array(), array( | ||
| 'allow_add' => true, | ||
| 'prototype' => true, | ||
| 'entry_type' => 'Symfony\Component\Form\Extension\Core\Type\TextType', |
|
@HeahDude thanks! Made new commit, now test is passing. |
| ))); | ||
| ), $options['options']); | ||
|
|
||
| if ($options['prototype_data'] !== null) { |
There was a problem hiding this comment.
Symfony CS prefers to use Yoda conditions: if (null !== $options['prototype_data']) {
There was a problem hiding this comment.
@sstok thanks! Fixed
|
👍 |
|
Thank you @memphys. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
…(memphys) This PR was squashed before being merged into the 2.8 branch (closes #17044). Discussion ---------- [Form] fix BC break introduced with prototype_data option | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [no] | Fixed tickets | [#15707] | License | MIT | Doc PR | [] This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity. - [x] make the test work (can't figure yet how to test that prototype without prototype_data option has default values) Commits ------- d73485a [Form] fix BC break introduced with prototype_data option
|
@fabpot with pleasure! |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 29, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fix regression on Collection type Q | A --- | --- Bug fix? | yes New feature? | no BC breaks? | no Deprecations? | no Tests pass? | yes Fixed tickets | License | MIT Doc PR | A regression was introduced in #17044. Commits ------- bd686cd [Form] Fixed regression on Collection type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the BC break introduced with prototype_data option in collection type. At the moment whether option is set or not it overwrites prototype data but it has different behaviour before and prototype data was taken from the mapped form data/entity.