fixed undefined variable #17527
Merged
fixed undefined variable #17527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Jan 25, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16653 |
| License | MIT |
| Doc PR | n/a |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
This PR was merged into the 2.3 branch. Discussion ---------- fixed undefined variable | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16653 | License | MIT | Doc PR | n/a Commits ------- 4b21351 fixed undefined variable
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Mar 1, 2016
…moving inadvertently added links (craue) This PR was merged into the 2.3 branch. Discussion ---------- [2.3][WebProfilerBundle] fix debug toolbar rendering by removing inadvertently added links | Q | A | ------------- | --- | Branch | 2.3+ | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The debug toolbar was broken by #17527... **before**  **and after**  **explanation** If `false` is explicitly passed for `link` then `link | default(true)` would evaluate to `true`, which is not what we want. The correct expression `link is not defined or link` was suggested originally in #16653. Commits ------- a0ddfc4 fix debug toolbar rendering by removing inadvertently added links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.