Skip to content

[Yaml] Fix tests #18098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016
Merged

[Yaml] Fix tests #18098

merged 1 commit into from
Mar 10, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #18093
License MIT
Doc PR -

now contains a TZ info (the current default TZ), so that the following ignores the injected TZ:
new \DateTime('now', new \DateTimeZone('UTC'))

An other fix is that since PHP 5.5.14, timestamps contains sub-seconds numbers that where previously ignored.

This fixes both issues.

@nicolas-grekas nicolas-grekas merged commit 25677fe into symfony:master Mar 10, 2016
nicolas-grekas added a commit that referenced this pull request Mar 10, 2016
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Yaml] Fix tests

| Q             | A
| ------------- | ---
| Branch        | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #18093
| License       | MIT
| Doc PR        | -

`now` contains a TZ info (the current default TZ), so that the following ignores the injected TZ:
`new \DateTime('now', new \DateTimeZone('UTC'))`

An other fix is that since PHP 5.5.14, timestamps contains sub-seconds numbers that where previously ignore.

This fixes both issues.

Commits
-------

25677fe [Yaml] Fix tests
@nicolas-grekas nicolas-grekas deleted the yaml-fix branch March 10, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants