Skip to content

[PropertyInfo] Support Doctrine custom mapping type in DoctrineExtractor #18209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

teohhanhui
Copy link
Contributor

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Also use Doctrine\DBAL\Types\Type class constants

@teohhanhui
Copy link
Contributor Author

@dunglas

Also use Doctrine\DBAL\Types\Type class constants
@teohhanhui teohhanhui force-pushed the fix-propertyinfo-doctrine-extractor branch from 1d76ea8 to 40e3e45 Compare March 17, 2016 08:00
@teohhanhui
Copy link
Contributor Author

Uhh, wrong branch... This should be merged against 2.8

@dunglas
Copy link
Member

dunglas commented Mar 17, 2016

👍

Status: Reviewed

ping @salahm

@fabpot
Copy link
Member

fabpot commented Mar 18, 2016

Thank you @teohhanhui.

fabpot added a commit that referenced this pull request Mar 18, 2016
…trineExtractor (teohhanhui)

This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #18209).

Discussion
----------

[PropertyInfo] Support Doctrine custom mapping type in DoctrineExtractor

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Also use Doctrine\DBAL\Types\Type class constants

Commits
-------

b50360f [PropertyInfo] Support Doctrine custom mapping type in DoctrineExtractor
@fabpot fabpot closed this Mar 18, 2016
@teohhanhui teohhanhui deleted the fix-propertyinfo-doctrine-extractor branch March 18, 2016 06:23
salahm added a commit to salahm/php-property-info that referenced this pull request Mar 22, 2016
This was referenced Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants