Skip to content

Exclude Bridge\PhpUnit from composer.json by default #18389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2016
Merged

Exclude Bridge\PhpUnit from composer.json by default #18389

merged 1 commit into from
Apr 1, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18381, #18272
License MIT
Doc PR -

This was referenced Mar 31, 2016
Closed
Closed
@fabpot
Copy link
Member

fabpot commented Apr 1, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4f90495 into symfony:2.7 Apr 1, 2016
fabpot added a commit that referenced this pull request Apr 1, 2016
@fabpot
minor #18389 Exclude Bridge\PhpUnit from composer.json by default (ni…
c5b792c 
…colas-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

Exclude Bridge\PhpUnit from composer.json by default

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18381, #18272
| License       | MIT
| Doc PR        | -

Commits
-------

4f90495 Exclude Bridge\PhpUnit from composer.json by default
@nicolas-grekas nicolas-grekas deleted the fix-autoload branch April 1, 2016 06:41
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 4, 2016
Closed
@OskarStark
Copy link
Contributor

OskarStark commented Apr 28, 2016 •
edited
Loading

Is this already merged in 2.8 @nicolas-grekas ?

I'm using:

symfony/symfony                          v2.8.4             The Symfony PHP framework
....
symfony/phpunit-bridge                   v2.8.4             Symfony PHPUnit Bridge

and still get this error!

edit
Looks like it is not fixed in SF 3.0.4, too: #18381 (comment)

@xabbuh
Copy link
Member

xabbuh commented Apr 28, 2016

@OskarStark You will need to wait for the next patch release.

@OskarStark
Copy link
Contributor

Thanks for the feedback @xabbuh i will! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @OskarStark @xabbuh @carsonbot