Skip to content

[Filesystem] do not use unlink for directories #18516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 12, 2016

Q A
Branch? to be merged into 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass?
Fixed tickets #18512
License MIT
Doc PR

@nicolas-grekas
Copy link
Member

#18515 should do it now

@xabbuh xabbuh force-pushed the issue-18512 branch 4 times, most recently from 4de3efc to 0bf5d83 Compare April 12, 2016 10:39
@xabbuh
Copy link
Member Author

xabbuh commented Apr 12, 2016

The failure seems to be related to the changes from #18272 (only the builds for the master branch export the SYMFONY_PHPUNIT_OVERLOAD that's also the reason why the builds didn't fail on my fork as I used a separate branch for testing) when being used with PHPUnit 4.8 (PHP 5.5 is the only job not using PHPUnit 5). Note that I disabled exporting the variable which made the bridge register more stuff. Though I am currently not sure how to fix this best (but we for sure don't seem to have to update the Filesystem component).

@xabbuh xabbuh closed this Apr 12, 2016
@xabbuh xabbuh deleted the issue-18512 branch September 29, 2016 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants