[Debug] fix resource type test on HHVM #19116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 20, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19079 |
| License | MIT |
| Doc PR |
|
Do we know why it broke without any change on our side? |
|
and this simply seems to be the returned value in all HVM versions: https://3v4l.org/D8sLi |
|
Looks like the tests still do not pass on HHVM. |
0e40d5d to
e1aad5f
Compare
|
Tests finally pass (we had to swap the expected and actual arguments for the assertions too). |
| @@ -193,6 +193,7 @@ public function flattenDataProvider() | |||
| public function testArguments() | |||
| { | |||
| $dh = opendir(__DIR__); | |||
| $fh = fopen($filename = tempnam(sys_get_temp_dir(), ''), 'r'); | |||
|
Tests do now pass again on HHVM. |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 20, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Debug] fix resource type test on HHVM | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19079 | License | MIT | Doc PR | Commits ------- 2d03ee8 [Debug] fix resource type test on HHVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.