[VarDumper] Fix dumping jsons casted as arrays #19368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 15, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19356 |
| License | MIT |
| Doc PR | - |
f0eb977 to
1a41265
Compare
| } | ||
| [1]=> | ||
| array(1) { | ||
| ["1"]=> |
There was a problem hiding this comment.
This is the important line: "1" instead of a plain 1. Only json_decode() can create these.
4b283fc to
a6906cc
Compare
a6906cc to
56549e7
Compare
|
Ready, with a bunch of really weird edge cases fixed when casting from array to object and vice versa. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 17, 2016
…ekas) This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Fix dumping jsons casted as arrays | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19356 | License | MIT | Doc PR | - Commits ------- 56549e7 [VarDumper] Fix dumping jsons casted as arrays
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.