[Validator][GroupSequence] fixed GroupSequence validation ignores PropetyMetadata of parent classes #19388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
senaria
commented
Jul 19, 2016
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19387 |
| License | MIT |
| Doc PR | N/A |
4c7e2aa to
1ff0611
Compare
…pertyMetadata of parent classes
1ff0611 to
9303fb2
Compare
|
Can we merge this in? |
|
Is there any news about this? This possible solution looks like it would really help us out. Would be great if you could have a closer look. |
|
@HeahDude Can you have a look at this one? |
|
LGTM 👍 @senaria Thank you for submitting this patch :) Status: reviewed |
|
Thank you @senaria. |
fabpot
added a commit
that referenced
this pull request
Aug 26, 2016
…ignores PropetyMetadata of parent classes (Sandro Hopf) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #19388). Discussion ---------- [Validator][GroupSequence] fixed GroupSequence validation ignores PropetyMetadata of parent classes | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19387 | License | MIT | Doc PR | N/A Commits ------- 54a7eff [Validator][GroupSequence] fixed GroupSequence validation ignores PropertyMetadata of parent classes
|
Brilliant. Thank you 👍 |
This was referenced Sep 2, 2016
Merged
Merged
Merged
This was referenced Dec 9, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.