Skip to content

[SwiftMailerBridge] Fix flawed deprecation message #19522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Aug 3, 2016

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Given __CLASS__ returns null outside of a class, the deprecation message is incomplete.

@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 9b0cbab into symfony:2.7 Aug 4, 2016
nicolas-grekas added a commit that referenced this pull request Aug 4, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[SwiftMailerBridge] Fix flawed deprecation message

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Given `__CLASS__` returns null outside of a class, the deprecation message is incomplete.

Commits
-------

9b0cbab Remove usage of __CLASS__ outside of a class
@chalasr chalasr deleted the fix_messagedatacollector_deprecation_msg branch August 4, 2016 10:29
This was referenced Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants