Fix translation:update command count #19878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c2046f to
ffdd15e
Compare
|
👍 |
|
Thank you @tgalopin. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Fix translation:update command count | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This issue fixes a bad count in the `translation:update` command. Previously, the number was badly calculated and doubled if the translation file didn't exists. Before: ``` Messages extracted for domain "messages" (2 messages) ----------------------------------------------------- * hello.world [OK] 2 messages were successfully extracted. ``` After: ``` Messages extracted for domain "messages" (1 message) ----------------------------------------------------- * hello.world [OK] 1 message was successfully extracted. ``` Commits ------- ffdd15e Fix translation:update command count
This was referenced Sep 13, 2016
nicolas-grekas
added a commit
that referenced
this pull request
Sep 13, 2016
… a merge (jakzal) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19921 | License | MIT | Doc PR | - #19325 relied on a wrong count of messages, which was fixed by #19878. Additionally, the `getContainer()` method on the master branch expect messages to be indexed by domain. Commits ------- d093c40 [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes a bad count in the
translation:updatecommand. Previously, the number was badly calculated and doubled if the translation file didn't exists.Before:
After: