Skip to content

removed obsolete images (since 2.2) #19996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2016

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 20, 2016

Q A
Branch? master
Bug fix? yes-ish (those files are not used since 2.2)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@fabpot
Copy link
Member Author

fabpot commented Sep 20, 2016

Added a second commit that removes a sync script that is not used anymore (since the redesign of the web profiler).

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

What about adding this change to the upgrade file? Someone might reference them for whatever reason in their own code.

@nicolas-grekas
Copy link
Member

👍

@fabpot fabpot force-pushed the obsolete-images-removal branch from b3bc58f to ae0b4e1 Compare September 21, 2016 14:17
@fabpot
Copy link
Member Author

fabpot commented Sep 21, 2016

@xabbuh good idea, I've just added the change to the CHANGELOG file (same in #19997 between).

@fabpot fabpot merged commit ae0b4e1 into symfony:master Sep 21, 2016
fabpot added a commit that referenced this pull request Sep 21, 2016
This PR was merged into the 3.2-dev branch.

Discussion
----------

removed obsolete images (since 2.2)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes-ish (those files are not used since 2.2)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

ae0b4e1 removed old script, not used anymore
9e8825b removed obsolete images (since 2.2)
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

@fabpot I think we should document these changes in UPGRADE-3.2.md too (but we can continue the discussion in #20014).

@fabpot fabpot deleted the obsolete-images-removal branch September 21, 2016 21:18
@fabpot fabpot mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants