Skip to content

[Console] Clarify behavior in ArgvInput #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] Clarify behavior in ArgvInput #20008

wants to merge 1 commit into from

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Sep 21, 2016

Q A
Branch? 2.7
Tests pass? yes
Fixed tickets #19946 (comment)
License MIT

@chalasr chalasr mentioned this pull request Sep 21, 2016
Merged
@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

@chalasr After I wrote the comment on your PR I realised that the behaviour of substr() was different before PHP 7.0. So we should at least check that this doesn't break anything here.

@chalasr
Copy link
Member Author

chalasr commented Sep 21, 2016

@xabbuh Indeed, there is side effects. Let's keep it as is

@chalasr chalasr closed this Sep 21, 2016
@chalasr chalasr deleted the console/argvinput_empty_opt branch September 21, 2016 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @xabbuh @carsonbot