[WIP] added missing ClassExistenceResource checks #20189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also add a DirectoryExistenceResource for translations for instance. If we add translations in a bundle, we should regerenate the cache, which is not the case right now. |
|
Finished in #21408, fixing your last comment too. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 2, 2017
…racking resource existence (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Add ContainerBuilder::fileExists() for checking/tracking resource existence | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20189, #20189 (comment) | License | MIT | Doc PR | n/a ~~Finishes #20189 Adds a convenient `ContainerBuilder::fileExists()` method as suggested by Nicolas and use it to track resources in the FrameworkExtension, adding some missing ones. Commits ------- 6b556b8 [DI] Add ContainerBuilder::fileExists()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #20121