[FrameworkBundle] Cache pool namespace added to configuration #20483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a doc PR to tell it exists, and most importantly tell why it's useful. |
|
@asev are you OK to create a PR on https://github.com/symfony/symfony-docs/ to document this configuration option? |
| @@ -732,6 +732,11 @@ private function assertCachePoolServiceDefinitionIsCreated(ContainerBuilder $con | |||
| $this->assertTrue(isset($tag[0]['default_lifetime']), 'The default lifetime is stored as an attribute of the "cache.pool" tag.'); | |||
| $this->assertSame($defaultLifetime, $tag[0]['default_lifetime'], 'The default lifetime is stored as an attribute of the "cache.pool" tag.'); | |||
|
|
|||
| if (null !== $namespace) { | |||
| $this->assertTrue(isset($tag[0]['namespace']), 'The namespace is stored as an attribute of the "cache.pool" tag.'); | |||
There was a problem hiding this comment.
I think we can remove this line: if the key does not exist, phpunit will throw a exception anyway on the next line.
|
But before going to write documentation, can you please tell us why this is useful? The namespace is currently automatically generated from the cache pool name and some container parameters, I don't see yet why we'd need something else. |
|
Replaced by #20616, which allows seeding the namespace from a user given config option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey. It's already checking for namespace at compiler pass. So I've added an ability to control it via config.