[Process] Do feat test before enabling TTY mode #20576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 21, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20565 |
| License | MIT |
| Doc PR | - |
80ee19a to
dfdd829
Compare
dfdd829 to
c2a4343
Compare
c2a4343 to
69bfbbf
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 22, 2016
…rekas) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Do feat test before enabling TTY mode | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20565 | License | MIT | Doc PR | - Commits ------- 69bfbbf [Process] Do feat test before enabling TTY mode
|
@fabpot this is happening in master |
|
@mayeco We always merge bugfix in the lowest affected, maintained branch. From there we merge up branches regularly. So each bugfix will end up in master eventually. |
|
@xabbuh Thank you! |
Merged
This was referenced Dec 13, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.