[HttpFoundation] Compute cookie max-age attribute #20644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one breaks tests and should be done in master as this is a new feature. |
|
Agree on master. I improved some affected tests already in #20569, preferably that goes first :) |
|
I think they are not really related and this one can probably be merged much faster than the other one :) |
|
Fair enough :) it's not the effort anyways.. ill update tests this evening 👍 |
ro0NL
commented
Dec 13, 2016
| @@ -72,9 +72,13 @@ public function testGetPath() | |||
|
|
|||
| public function testGetExpiresTime() | |||
| { | |||
| $cookie = new Cookie('foo', 'bar', 3600); | |||
There was a problem hiding this comment.
Updated tests that are passing 3600 as expire time as well. 3600 implies max-age value, not a expire time. This was rather confusing :)
|
Ready. Failing test (PHP7/redis) seems unrelated. edit; apparently HHVM differs on the |
|
Truly ready 👍 (also no conflict with #20910) |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Dec 15, 2016
This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpFoundation] Compute cookie max-age attribute | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | License | MIT | Doc PR | reference to the documentation PR, if any See https://wiki.php.net/rfc/cookie_max-age, PHP sends it since 5.5. ~~The date format actually differs now from PHP (`Saturday` instead of `Sat`). But it really doesnt matter much imo, using the constant seems more reliable to me and max-age overrules anyway ;)~~ Relates to #20569 Commits ------- 8c28317 [HttpFoundation] Compute cookie max-age attribute
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://wiki.php.net/rfc/cookie_max-age, PHP sends it since 5.5.
The date format actually differs now from PHP (Saturdayinstead ofSat). But it really doesnt matter much imo, using the constant seems more reliable to me and max-age overrules anyway ;)Relates to #20569