[Validator] add class name to the cache key #20745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28454d0 to
122c01d
Compare
dunglas
requested changes
Dec 6, 2016
| { | ||
| /** | ||
| * @Assert\Valid | ||
| * @Assert\NotBlank |
There was a problem hiding this comment.
You should use another assertion to be sure that there is no collision.
dunglas
approved these changes
Dec 8, 2016
|
👍 |
stof
reviewed
Dec 8, 2016
| protected $lastName; | ||
| public $reference; | ||
| public $reference2; | ||
| private $internal; | ||
| public $data = 'Overridden data'; | ||
| public $initialized = false; | ||
|
|
|
Thank you @Simperfit. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2016
This PR was squashed before being merged into the 3.1 branch (closes #20745). Discussion ---------- [Validator] add class name to the cache key | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20685 | License | MIT | Doc PR | Adding the class name to the cache key to avoid collision Commits ------- 1681fc9 [Validator] add class name to the cache key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the class name to the cache key to avoid collision