[Twig] Fix deprecations with Twig 1.29 #20831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 8, 2016
•
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20829 |
| License | MIT |
| Doc PR | - |
|
@nicolas-grekas can you also check deprecations in the profiler ? #20829 makes me think we have some there too |
f1affb7 to
9218cac
Compare
|
@stof updated |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Twig] Fix deprecations with Twig 1.29 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20829 | License | MIT | Doc PR | - Commits ------- 9218cac [Twig] Fix deprecations with Twig 1.29
This was referenced Dec 13, 2016
Merged
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jan 10, 2017
…dling (Bertalan Attila) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] Fixing regression in TwigEngine exception handling | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21176 | License | MIT Fixing regression after #20831 in TwigEngine exception handling. Commits ------- 390cb33 Fixing regression in TwigEngine exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.