fixed obsolete getMock() usage #20984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bfa104 to
bb36fa6
Compare
b1d8553 to
3ba84ac
Compare
fabpot
added a commit
that referenced
this pull request
Dec 19, 2016
This PR was merged into the 2.7 branch. Discussion ---------- fixed obsolete getMock() usage | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Let's do it. Commits ------- 71d059c fixed obsolete getMock() usage
|
Why not? |
|
@hugohenrique |
|
And to be honest, I prefer to use the same way everywhere. |
|
hurray for it. We will be able to upgrade simple-phpunit to use a more recent version of PHPUnit 5.x then |
|
The same PR needs to be submitted against 2.8 now, then etc up to master :) |
|
I've of course done that already
… On 20 Dec 2016, at 10:24, Nicolas Grekas ***@***.***> wrote:
The same PR needs to be submitted against 2.8 now, then etc up to master :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's do it.