[FrameworkBundle] Make TemplateController working without the Templating component #21034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
918c9d3 to
5ce9222
Compare
Simperfit
approved these changes
Dec 23, 2016
5ce9222 to
89ccbc4
Compare
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2016
…the Templating component (dunglas) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Make TemplateController working without the Templating component | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The template controller was missed during #15502. Btw I've added some tests for this controller. Commits ------- 89ccbc4 [FrameworkBundle] Make TemplateController working without the Templating component
xabbuh
reviewed
Dec 23, 2016
| @@ -33,8 +33,14 @@ class TemplateController extends ContainerAware | |||
| */ | |||
| public function templateAction($template, $maxAge = null, $sharedAge = null, $private = null) | |||
| { | |||
| /** @var $response \Symfony\Component\HttpFoundation\Response */ | |||
| $response = $this->container->get('templating')->renderResponse($template); | |||
| /* @var $response \Symfony\Component\HttpFoundation\Response */ | |||
There was a problem hiding this comment.
@dunglas Are you sure about this change?
There was a problem hiding this comment.
I would even remove it as I don't think it helps in any way, does it?
There was a problem hiding this comment.
Removing it would indeed be better.
There was a problem hiding this comment.
It was to make fabbot green, I've tried with PHPStorm, both formats enable the autocompletion. Removing it prevent autocompletion by default, but if you have the Symfony plugin then it works.
This was referenced Jan 12, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template controller was missed during #15502. Btw I've added some tests for this controller.