[Bridge/PhpUnit] Relax expectedDeprecation for forward compat #21186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2017
…pat (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [Bridge/PhpUnit] Relax expectedDeprecation for forward compat | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Instead of a strict match, this makes the annotation check ignore not expected messages, while still requiring all the expected ones in order. This is needed for forward compat with future deprecations, and should make travis green again. Commits ------- a3ba726 [Bridge/PhpUnit] Relax expectedDeprecation for forward compat
|
This still enforces the order of deprecations. Shouldn't we assert each expected deprecation separately instead ? |
|
We never had an issue with ordering, so no need I'd say, this keeps the implementation simple. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a strict match, this makes the annotation check ignore not expected messages, while still requiring all the expected ones in order.
This is needed for forward compat with future deprecations, and should make travis green again.