[HttpFoundation] Mark more methods as @final
#21461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Jan 30, 2017
| @@ -752,6 +790,8 @@ public function setExpires(\DateTime $date = null) | |||
| * back on an expires header. It returns null when no maximum age can be established. | |||
| * | |||
| * @return int|null Number of seconds | |||
| * | |||
| * @final since version 3.2 | |||
There was a problem hiding this comment.
Should we support the annotations on methods in the DebugClassLoader ?
There was a problem hiding this comment.
I can't do it right now, but i will asap.
GuilhemN
approved these changes
Jan 30, 2017
xabbuh
reviewed
Jan 30, 2017
| @@ -465,6 +469,8 @@ public function getContent() | |||
| * @param string $version The HTTP protocol version | |||
| * | |||
| * @return $this | |||
| * | |||
| * @final since version 3.2 | |||
There was a problem hiding this comment.
Shouldn't this be 3.3 everywhere?
There was a problem hiding this comment.
@final support is since 3.3, but the method is final since 3.2 - see deprecation in the constructor
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 30, 2017
…grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpFoundation] Mark more methods as `@final` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #19734 (ping @GuilhemN) Commits ------- 84a664f [HttpFoundation] Mark more methods as `@final`
fabpot
added a commit
that referenced
this pull request
Feb 12, 2017
This PR was squashed before being merged into the 3.3-dev branch (closes #21465). Discussion ---------- [Debug] Support `@final` on methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21461 (comment) | License | MIT | Doc PR | This adds support for `@final` on methods: ```php class Foo { /** * @Final since version 2.0. */ public function bar() { } } ``` ping @nicolas-grekas Commits ------- 1b0a6b6 [Debug] Support on methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #19734 (ping @GuilhemN)