[SecurityBundle] simplified code #21709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to be explicit about the supported versions (should be |
stof
reviewed
Feb 22, 2017
| $voters = call_user_func_array('array_merge', $voters); | ||
|
|
||
| if (!$voters) { | ||
| throw new LogicException('No security voters found. You need to tag at least one with "security.voter"'); |
There was a problem hiding this comment.
this exception is gone. Is it expected ?
9961ccb to
e713ceb
Compare
e713ceb to
512742b
Compare
fabpot
added a commit
that referenced
this pull request
Feb 23, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [SecurityBundle] simplified code | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Simplified code for 3.2 (followup to #21679) Commits ------- 512742b [SecurityBundle] simplified code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified code for 3.2 (followup to #21679)