[Form] Minor: Fix comment in ChoiceType #22673
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
May 9, 2017
| @@ -162,7 +162,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| } | |||
|
|
|||
| // To avoid issues when the submitted choices are arrays (i.e. array to string conversions), | |||
| // we have to ensure that all elements of the submitted choice data are strings or null. | |||
| // we have to ensure that all elements of the submitted choice data are NULL, strings or ints. | |||
There was a problem hiding this comment.
To conform with exception message👼
ro0NL
approved these changes
May 9, 2017
|
Good catch, thanks @issei-m. |
fabpot
added a commit
that referenced
this pull request
May 9, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Minor: Fix comment in ChoiceType | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a Forgotten to be updated in: #21957 Commits ------- a49d79c [Form] Minor: Fix comment in ChoiceType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgotten to be updated in: #21957