-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PhpUnitBridge] remove deprecated features #22792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:master
from
xabbuh:phpunit-bridge-remove-deprecated-features
May 21, 2017
Merged
[PhpUnitBridge] remove deprecated features #22792
fabpot
merged 1 commit into
symfony:master
from
xabbuh:phpunit-bridge-remove-deprecated-features
May 21, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 20, 2017
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | no |
BC breaks? | yes |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
7d95008
to
a3761e9
Compare
nicolas-grekas
approved these changes
May 20, 2017
Tobion
reviewed
May 20, 2017
@@ -16,7 +16,6 @@ | |||
use PHPUnit\Framework\TestCase; | |||
use PHPUnit\Framework\TestSuite; | |||
use PHPUnit\Util\Blacklist; | |||
use PHPUnit\Util\Test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems to be unused also in earlier versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #22816
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] remove unused use statement | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22792 (comment) | License | MIT | Doc PR | Commits ------- c36ea03 [PhpUnitBridge] remove unused use statement
changelog missing |
a3761e9
to
80ac46f
Compare
80ac46f
to
8baa689
Compare
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [PhpUnitBridge] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 8baa689 [PhpUnitBridge] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.