Skip to content

[PhpUnitBridge] remove deprecated features #22792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 20, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.0 milestone May 20, 2017
@xabbuh xabbuh force-pushed the phpunit-bridge-remove-deprecated-features branch from 7d95008 to a3761e9 Compare May 20, 2017 06:11
@@ -16,7 +16,6 @@
use PHPUnit\Framework\TestCase;
use PHPUnit\Framework\TestSuite;
use PHPUnit\Util\Blacklist;
use PHPUnit\Util\Test;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems to be unused also in earlier versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #22816

nicolas-grekas added a commit that referenced this pull request May 21, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

[PhpUnitBridge] remove unused use statement

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22792 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

c36ea03 [PhpUnitBridge] remove unused use statement
@nicolas-grekas
Copy link
Member

changelog missing

@xabbuh xabbuh force-pushed the phpunit-bridge-remove-deprecated-features branch from a3761e9 to 80ac46f Compare May 21, 2017 17:35
@xabbuh xabbuh force-pushed the phpunit-bridge-remove-deprecated-features branch from 80ac46f to 8baa689 Compare May 21, 2017 17:42
@xabbuh
Copy link
Member Author

xabbuh commented May 21, 2017

changelog added (see #22834 and #22835 for related changes in older branches)

@fabpot
Copy link
Member

fabpot commented May 21, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 8baa689 into symfony:master May 21, 2017
fabpot added a commit that referenced this pull request May 21, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

[PhpUnitBridge] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

8baa689 [PhpUnitBridge] remove deprecated features
@xabbuh xabbuh deleted the phpunit-bridge-remove-deprecated-features branch May 21, 2017 18:43
@fabpot fabpot mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants