[VarDumper] Cycle prev/next searching in HTML dumps #22917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ro0NL! The current behavior was my own preference: I don't like the cyclic search actually. |
|
Perhaps im too much used to it... it's really common though =/ (gedit, firefox, chrome, office) Phpstorm preserves one enter (which i find annoying :) Ill keep it open for now, lets see what others think. Otherwise your call :) The case-insenstive search also happens in all mentioned above. That should be patched at least. |
|
Moved to milestone 3.4 |
|
Thank you @ro0NL. |
fabpot
approved these changes
Jun 9, 2017
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
…o0NL) This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #22917). Discussion ---------- [VarDumper] Cycle prev/next searching in HTML dumps | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> This cycles the prev/next searching in html dumps and mimics (at least) chrome's search bar. It's truly convenient, hence 3.3 cc @ogizanagi Commits ------- 73f24e8 search case insensitive 0821c5a [VarDumper] Cyclic searching dumps
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cycles the prev/next searching in html dumps and mimics (at least) chrome's search bar. It's truly convenient, hence 3.3
cc @ogizanagi