Skip to content

[3.4] Implement ServiceSubscriberInterface in optional cache warmers #23036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2017
Merged

[3.4] Implement ServiceSubscriberInterface in optional cache warmers #23036

merged 1 commit into from
Jun 3, 2017

Conversation

romainneutron
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT

@romainneutron romainneutron changed the title Implement ServiceSubscriberInterface in optional cache warmers [3.4] Implement ServiceSubscriberInterface in optional cache warmers Jun 2, 2017
@romainneutron romainneutron force-pushed the 3.4-cache-warmers-service-subscribers branch from e75a8bb to 4ba59c9 Compare June 2, 2017 15:02
nicolas-grekas
nicolas-grekas approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 June 2, 2017 15:07
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 2, 2017
@nicolas-grekas
Copy link
Member

Thank you @romainneutron.

@nicolas-grekas nicolas-grekas merged commit 4ba59c9 into symfony:3.4 Jun 3, 2017
nicolas-grekas added a commit that referenced this pull request Jun 3, 2017
@nicolas-grekas
feature #23036 [3.4] Implement ServiceSubscriberInterface in optional…
4fbc2a6 
… cache warmers (romainneutron)

This PR was merged into the 3.4 branch.

Discussion
----------

[3.4] Implement ServiceSubscriberInterface in optional cache warmers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT

Commits
-------

4ba59c9 Implement ServiceSubscriberInterface in optional cache warmers
@romainneutron romainneutron deleted the 3.4-cache-warmers-service-subscribers branch June 5, 2017 08:37
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@romainneutron @nicolas-grekas @carsonbot