Skip to content

[Form] Missing deprecated paths removal #23046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2017
Merged

[Form] Missing deprecated paths removal #23046

merged 1 commit into from
Jun 3, 2017

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jun 3, 2017 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

ogizanagi
ogizanagi commented Jun 3, 2017
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Resources/config/form_debug.xml
@@ -26,7 +26,6 @@
<service id="data_collector.form" class="Symfony\Component\Form\Extension\DataCollector\FormDataCollector" public="true">
<tag name="data_collector" template="@WebProfiler/Collector/form.html.twig" id="form" priority="310" />
<argument type="service" id="data_collector.form.extractor" />
<argument>false</argument>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this one should be done in lower branches too. See #23048

@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 761bcca into symfony:master Jun 3, 2017
nicolas-grekas added a commit that referenced this pull request Jun 3, 2017
@nicolas-grekas
feature #23046 [Form] Missing deprecated paths removal (ogizanagi)
19c4bb7 
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Form] Missing deprecated paths removal

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | yes
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

761bcca [Form] Missing deprecated paths removal
@ogizanagi ogizanagi deleted the rm_deprec/form branch June 3, 2017 08:41
@fabpot fabpot mentioned this pull request Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break Form Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @nicolas-grekas @carsonbot