Skip to content

[WebProfilerBundle] Remove WebProfilerExtension::dumpValue() #23056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2017
Merged

[WebProfilerBundle] Remove WebProfilerExtension::dumpValue() #23056

merged 1 commit into from
Jun 3, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@fabpot
Copy link
Member

fabpot commented Jun 3, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 9fe5102 into symfony:master Jun 3, 2017
fabpot added a commit that referenced this pull request Jun 3, 2017
…alue() (ogizanagi)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[WebProfilerBundle] Remove WebProfilerExtension::dumpValue()

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | yes
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

9fe5102 [WebProfilerBundle] Remove WebProfilerExtension::dumpValue()
@ogizanagi ogizanagi deleted the rm_deprec/web_profiler_bundle branch June 4, 2017 05:13
@fabpot fabpot mentioned this pull request Oct 19, 2017
morticue added a commit to rdey/GordalinaMixpanelBundle that referenced this pull request Jun 18, 2020
The profiler panel does not work due to outdated usage of the "@WebProfiler/Profiler/table.html.twig" template where the value passed to the profiler_dump twig extension has changed in this PR symfony/symfony#23056

Also the twig template path syntax used in the data collector config and its template should be updated. It is however possible to work arround this issue by including symfony/templating and add the config framework.templating.engines: ['twig']
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants