[Console] Fix catching exception type in QuestionHelper #23240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstok
approved these changes
Jun 21, 2017
|
Failure seems unrelated. Status: reviewed |
|
Thank you @voronkovich. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2017
…oronkovich) This PR was merged into the 2.8 branch. Discussion ---------- [Console] Fix catching exception type in QuestionHelper | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When generic exceptions were replaced by domain exceptions in dd17dc0 one catch statement was missed. The existing code works fine because a `RuntimeException` extends a `\RuntimeException`. Commits ------- 1c091eb [Console] Fix catching exception type in QuestionHelper
This was referenced Jul 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generic exceptions were replaced by domain exceptions in dd17dc0 one catch statement was missed. The existing code works fine because a
RuntimeExceptionextends a\RuntimeException.