[Security] Fix authentication.failure event not dispatched on AccountStatusException #23256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51a2195 to
0d98cac
Compare
0d98cac to
00867fd
Compare
|
This changes the behaviour of when you have more than one authentication provider and one of them throws an |
00867fd to
64c2efd
Compare
|
@xabbuh indeed, fixed |
xabbuh
approved these changes
Jul 5, 2017
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 12, 2017
… on AccountStatusException (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [Security] Fix authentication.failure event not dispatched on AccountStatusException | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18807 | License | MIT | Doc PR | n/a Authentication fails if the user exists but its account is disabled/expired/locked, the failure event should be dispatched in this case, so that you can hook into as for any authentication exception. Commits ------- 64c2efd [Security] Fix authentication.failure event not dispatched on AccountStatusException
This was referenced Jul 17, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication fails if the user exists but its account is disabled/expired/locked, the failure event should be dispatched in this case, so that you can hook into as for any authentication exception.