[FrameworkBundle] disable unusable fragment renderers #23272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 22, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21733 |
| License | MIT |
| Doc PR |
xabbuh
commented
Jun 22, 2017
| @@ -13,6 +13,7 @@ | |||
| <xsd:element name="form" type="form" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="csrf-protection" type="csrf_protection" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="esi" type="esi" minOccurs="0" maxOccurs="1" /> | |||
| <xsd:element name="ssi" type="ssi" minOccurs="0" maxOccurs="1" /> | |||
There was a problem hiding this comment.
this must be fixed in lower branches too (see #23271)
dunglas
approved these changes
Jun 24, 2017
57db149 to
90b4213
Compare
fabpot
approved these changes
Jul 3, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
…(xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] disable unusable fragment renderers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21733 | License | MIT | Doc PR | Commits ------- 2b3d7f0 disable unusable fragment renderers
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
… (xabbuh) This PR was merged into the 3.2 branch. Discussion ---------- [TwigBundle] gracefully handle missing hinclude renderer | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #23272 the `ExtensionPass` from the TwigBundle will error when being used with FrameworkBundle 3.4 thus letting all `deps=high` build jobs fail. Commits ------- ebdbecf gracefully handle missing hinclude renderer
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.